gfphoenix78 commented on code in PR #1228:
URL: https://github.com/apache/cloudberry/pull/1228#discussion_r2204206011


##########
src/backend/gporca/libnaucrates/src/md/CMDName.cpp:
##########
@@ -75,7 +75,7 @@ CMDName::CMDName(const CMDName &name)
 //---------------------------------------------------------------------------
 CMDName::~CMDName()
 {
-       GPOS_ASSERT(m_name->IsValid());
+       // Current `m_name` may have been destroyed.

Review Comment:
   We may add more details on why the pointer is invalid: the name could be 
reference only, there is no guarantee that the referenced object lives longer 
than the CMDName object when running the destructor of a process.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to