avamingli commented on code in PR #1223:
URL: https://github.com/apache/cloudberry/pull/1223#discussion_r2209158192
##########
src/backend/access/gin/ginpostinglist.c:
##########
@@ -335,7 +335,13 @@ ginPostingListDecodeAllSegments(GinPostingList *segment,
int len, int *ndecoded_
}
/* copy the first item */
+ /*
+ * Keep this commented out.
+ * See comments in itemptr_to_uint64().
+ */
+#if 0
Assert(OffsetNumberIsValid(ItemPointerGetOffsetNumber(&segment->first)));
Review Comment:
I think we need test cases that reproduce the issues for other indexes, then
fix them one by one and add regression tests to prevent future breaks
Without concrete examples, we can't verify our fixes actually work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
