tuhaihe commented on code in PR #1238: URL: https://github.com/apache/cloudberry/pull/1238#discussion_r2212868322
########## contrib/pax_storage/src/cpp/cpp-stub/LICENSE: ########## @@ -0,0 +1,21 @@ +MIT License Review Comment: Hey @jiaqizho, I'm curious and want to learn more about your option - its location is different from the traditional style. Can it be viewed as the same class as other feature directories? Although we’ve changed the way of introducing `cpp-stub`, it can still be considered a third-party dependency, and the contrib is where it will be, from my understanding. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudberry.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cloudberry.apache.org For additional commands, e-mail: commits-h...@cloudberry.apache.org
