avamingli commented on PR #1250: URL: https://github.com/apache/cloudberry/pull/1250#issuecomment-3096940597
> We used the function list_append_unique_oid, which has a complexity of O(n) compared to O(1) of BitmapSet. Shall we have a test on TPC-DS to see if there is any performance regression in data loading? YES,this quick fix may be less efficient for deduplication than Bitmapset, it provides correct behavior for all OID values. Need to think other approaches if we're concerned about performance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudberry.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cloudberry.apache.org For additional commands, e-mail: commits-h...@cloudberry.apache.org
