weinan003 commented on code in PR #1308:
URL: https://github.com/apache/cloudberry/pull/1308#discussion_r2268734144
##########
gpMgmt/bin/gpstart:
##########
@@ -55,7 +55,8 @@ class GpStart:
skip_heap_checksum_validation=False,
fts_hosts=None,
etcd_hosts=None,
- is_external_fts=False
+ is_external_fts=False,
+ segment_config_file=None
Review Comment:
不建议直接把segment config file配置的选项暴露给用户，以免错配后我们需要大量的鲁棒性检查
##########
src/backend/access/transam/xlog.c:
##########
@@ -6629,7 +6629,16 @@ UpdateCatalogForStandbyPromotion(void)
/* I am privileged */
InitializeSessionUserIdStandalone();
gp_activate_standby();
- write_gp_segment_configuration();
+
+ if (gp_segment_configuration_file &&
access(gp_segment_configuration_file, F_OK) == 0)
+ {
+ write_gp_segment_configuration();
Review Comment:
如果把重写gp_segment_configuration的逻辑放在内核中，就需要在内核regress测试中有回归测试进行保护。建议使用标准SQL在CBDR项目中完成这部分逻辑，并在CBDR中进行回归测试
##########
src/backend/utils/misc/guc_gp.c:
##########
@@ -5043,7 +5043,7 @@ struct config_string ConfigureNamesString_gp[] =
check_gp_interconnect_type, assign_gp_interconnect_type,
show_gp_interconnect_type
},
{
- {"gp_pause_on_restore_point_replay", PGC_SUSET,
DEVELOPER_OPTIONS,
Review Comment:
先spike一下pg的GUC option
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cloudberry.apache.org
For additional commands, e-mail: commits-h...@cloudberry.apache.org
