robertmu opened a new pull request, #20:
URL: https://github.com/apache/cloudberry-gpbackup/pull/20

   The integration test for `GetDatabaseRoles` was failing on Cloudberry 
because the expected password hash format did not match the actual value 
returned by the database.
   
   The test was hard-coded to expect an MD5 password hash, but the Cloudberry 
instance uses the more secure SCRAM-SHA-256 by default(PostgreSQL 14). This 
resulted in a string mismatch failure.
   
   This commit adapts the test to handle this difference specifically for 
Cloudberry. When running against a Cloudberry instance, the test now:
   1. Asserts that the returned password hash has the "SCRAM-SHA-256$" prefix, 
confirming the correct algorithm is used.
   2. Clears the password fields from both the expected and actual structs 
before the final comparison, as the full salted hash is unpredictable.
   
   The test logic for all Greenplum versions remains unchanged, preserving the 
original MD5 hash validation for those environments.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudberry.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cloudberry.apache.org
For additional commands, e-mail: commits-h...@cloudberry.apache.org

Reply via email to