This is an automated email from the ASF dual-hosted git repository.
gfphoenix78 pushed a commit to branch sync-with-upstream
in repository https://gitbox.apache.org/repos/asf/cloudberry-gpbackup.git
The following commit(s) were added to refs/heads/sync-with-upstream by this
push:
new 62fc64dd fix(test): Skip failing storage options query test on
Cloudberry (#25)
62fc64dd is described below
commit 62fc64dd41fca426856515fc0e2c5937b1c969ef
Author: Robert Mu <db...@hotmail.com>
AuthorDate: Thu Aug 28 20:30:10 2025 +0800
fix(test): Skip failing storage options query test on Cloudberry (#25)
Temporarily skips the `GetTableStorage` integration test on Cloudberry.
The test fails because Cloudberry, unlike GPDB 7, does not persist
default storage options to `pg_class.reloptions` when an append-optimized
table is created with only `appendonly=true`.
This inconsistency causes the test to fail as it expects the default
storage option string but receives an empty one from the query.
A TODO comment has been added to re-enable the test once the underlying
issue in Cloudberry is resolved.
See: https://github.com/apache/cloudberry/issues/1260
---
integration/predata_table_defs_queries_test.go | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/integration/predata_table_defs_queries_test.go
b/integration/predata_table_defs_queries_test.go
index e60946e0..b67f4919 100644
--- a/integration/predata_table_defs_queries_test.go
+++ b/integration/predata_table_defs_queries_test.go
@@ -808,6 +808,30 @@ SET SUBPARTITION TEMPLATE
Expect(result[oid]).To(Equal(""))
})
It("returns a value for storage options of a table ", func() {
+ /*
+ * This test is expected to fail on Cloudberry due to
an inconsistency
+ * in its handling of default table storage options for
simple
+ * append-optimized tables.
+ *
+ * The test creates an AO table with only
`appendonly=true`. The test logic
+ * expects that for GPDB 7+ and Cloudberry, this would
trigger the
+ * population of all default storage options (like
blocksize, compresstype,
+ * and checksum) into the table's metadata.
+ *
+ * While GPDB 7+ behaves this way, Cloudberry does not.
It leaves the
+ * `pg_class.reloptions` column as NULL for this
specific case. As a result,
+ * `gpbackup` correctly reads no storage options,
causing a mismatch with the
+ * hardcoded expectation for GPDB 7+ behavior.
+ */
+
+ // TODO: Remove this skip once Cloudberry consistently
persists default
+ // storage options to pg_class.reloptions for simple AO
tables, mirroring
+ // the behavior of GPDB 7+. The current issue causes
GetTableStorage to
+ // return an empty string instead of the expected
defaults.
+ if connectionPool.Version.IsCBDB() {
+ Skip("Test temporarily disabled for Cloudberry
due to non-persistence of default storage options")
+ }
+
testhelper.AssertQueryRuns(connectionPool, "CREATE
TABLE public.ao_table(i int) with (appendonly=true)")
defer testhelper.AssertQueryRuns(connectionPool, "DROP
TABLE public.ao_table")
oid := testutils.OidFromObjectName(connectionPool,
"public", "ao_table", backup.TYPE_RELATION)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cloudberry.apache.org
For additional commands, e-mail: commits-h...@cloudberry.apache.org
