robertmu commented on PR #38: URL: https://github.com/apache/cloudberry-gpbackup/pull/38#issuecomment-3241380573
> Why do we still run the tests for gpdb 4? Thanks for the question! There are two important points to clarify: 1. Current Support: gpbackup still actively supports GPDB 4, so having GPDB 4-related tests is expected and necessary to ensure backward compatibility. 2. File Naming Convention: The file name gpdb4_objects.sql means this SQL file is compatible with GPDB 4 and later versions (i.e., backward compatible down to GPDB 4). If you check the resources directory, you'll find we follow this pattern consistently: * gpdb4_objects.sql - runs on GPDB 4+ * gpdb5_objects.sql - runs on GPDB 5+ * gpdb6_objects.sql - runs on GPDB 6+ The test logic in `plugin_test.go` demonstrates this - it conditionally executes different object files based on the database version being tested. This approach allows us to test version-specific features while maintaining comprehensive coverage across all supported GPDB versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudberry.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cloudberry.apache.org For additional commands, e-mail: commits-h...@cloudberry.apache.org
