zhangyue1818 commented on code in PR #1365:
URL: https://github.com/apache/cloudberry/pull/1365#discussion_r2367245479
##########
contrib/interconnect/udp/ic_udpifc.c:
##########
@@ -3284,13 +3733,49 @@ static inline void
SetupUDPIFCInterconnect(EState *estate)
{
ChunkTransportState *icContext = NULL;
+ int32 sliceNum = 0;
+ int32 calcQueueDepth = 0;
+ int32 calcSndDepth = 0;
PG_TRY();
{
/*
* The rx-thread might have set an error since last teardown,
* technically it is not part of current query, discard it
directly.
*/
resetRxThreadError();
+ if (estate != NULL && estate->es_sliceTable != NULL)
+ sliceNum = estate->es_sliceTable->numSlices;
+ else
+ sliceNum = 1;
+
+ if (Gp_interconnect_mem_size > 0 &&
+ Gp_interconnect_queue_depth == 4 &&
Review Comment:
It will not work if the default value of Gp_interconnect_snd_queue_depth
or/and Gp_interconnect_queue_depth changes. It's better use the same const
macro in guc_gp.c and here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cloudberry.apache.org
For additional commands, e-mail: commits-h...@cloudberry.apache.org
