robertmu commented on issue #57: URL: https://github.com/apache/cloudberry-backup/issues/57#issuecomment-3395695227
> Hi [@robertmu](https://github.com/robertmu), thanks for your reply. So we can add `make unit` without specifying the GPDB version, which is for Cloudberry? > > [cloudberry-backup/.github/workflows/build_and_unit_test.yml](https://github.com/apache/cloudberry-backup/blob/d07ce985d794008a44182a237e20e0ea2eaffa0c/.github/workflows/build_and_unit_test.yml#L41-L44) > > Lines 41 to 44 in [d07ce98](/apache/cloudberry-backup/commit/d07ce985d794008a44182a237e20e0ea2eaffa0c) > > - name: Unit Test > run: | > cd ${GOPATH}/src/github.com/apache/cloudberry-backup > make unit_all_gpdb_versions Yes, I agree that the current implementation in build_and_unit_test.yml is correct. The key improvement we need to make is within the unit_all_gpdb_versions target itself. We should enhance it to support setting parameters like testDbType=CBDB or testDbType=GPDB, along with a specific TEST_DB_VERSION (e.g., 4.0.0), before running the unit tests for each version. This will make our compatibility testing more robust and explicit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
