tuhaihe commented on code in PR #1446:
URL: https://github.com/apache/cloudberry/pull/1446#discussion_r2629770996
##########
GNUmakefile.in:
##########
@@ -116,6 +122,9 @@ clean:
# gpAux/Makefile is the entry point for the enterprise build, which ends up
# calling top-level configure and this Makefile
$(MAKE) -C gpMgmt $@
+ifeq ($(enable_mcp_server), yes)
Review Comment:
Thanks for the suggestion. I followed the same pattern as `enable_pax` which
also uses `ifeq` directly in GNUmakefile.in.
Since mcp-server is a top-level optional component (not used by `src/`
subdirectories), keeping it in `GNUmakefile.in` seems appropriate. But I'm open
to moving it to `Makefile.global.in` if you prefer consistency with other
enable_* flags.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
