leborchuk commented on PR #1434: URL: https://github.com/apache/cloudberry/pull/1434#issuecomment-3858376758
> Thanks for the review and feedback! > > I agree that installing Python dependencies implicitly in the build system is not ideal in the long term, especially with PEP 668 and distro packaging policies. > > For this PR, I’d like to keep the current behavior for compatibility reasons (it is consistent with the existing build logic and avoids breaking current users and CI environments). This change mainly addresses the Ubuntu 24.04 build failure while preserving backward compatibility. > > As a follow-up, I plan to propose a cleaner approach: > > * Remove implicit pip installation from the build process. > * Recommend users to install Python dependencies explicitly via `pip3 install -r python-dependencies.txt` (or via venv / distro packages). > * Update the build documentation accordingly and make the build fail fast if required Python modules are missing. > > This would align better with reproducible builds and packaging best practices, but it should be done in a phased manner to avoid disrupting existing workflows. > > How about this? @leborchuk @gfphoenix78 Yes, that's normal. Here we try to solve the issue that code does not work in Ubuntu 24.04. Of course, the whole approach should be reconsidered, we should just instruct script user how to prepare environment or get the prepared environment for him. But do not change the environment yourself. It'd be better to change it in another PR. Do not confuse doing a big refactoring with supporting Ubuntu 24.04 altogether. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
