ostinru commented on code in PR #55:
URL: https://github.com/apache/cloudberry-pxf/pull/55#discussion_r2772726954
##########
README.md:
##########
@@ -78,43 +74,35 @@ To build PXF, you must have:
go install github.com/onsi/ginkgo/ginkgo@latest
```
-5. cURL (7.29 or later):
-
- To install cURL devel package on CentOS 7, `sudo yum install
libcurl-devel`.
-
- Note that CentOS 6 provides an older, unsupported version of cURL (7.19).
You should install a newer version from source if you are on CentOS 6.
-
-### How to Build PXF
+### Build PXF
PXF uses Makefiles to build its components. PXF server component uses Gradle
that is wrapped into the Makefile for convenience.
```bash
-cd ~/workspace/pxf
+cd ~/pxf
-# Compile & Test PXF
+# Compile PXF
make
-
-# Only run unit tests
-make test
```
-### How to Install PXF
+### Install PXF
-To install PXF, first make sure that the user has sufficient permissions in
the `$GPHOME` and `$PXF_HOME` directories to perform the installation. It's
recommended to change ownership to match the installing user. For example, when
installing PXF as user `gpadmin` under `/usr/local/cloudberrydb`:
+To install PXF, first make sure that the user has sufficient permissions in
the `$GPHOME` and `$PXF_HOME` directories to perform the installation. It's
recommended to change ownership to match the installing user. For example, when
installing PXF as user `gpadmin` under `/usr/local/cloudberry-db`:
```bash
-export GPHOME=/usr/local/cloudberrydb
+mkdir -p /usr/local/pxf
+export GPHOME=/usr/local/cloudberry-db
export PXF_HOME=/usr/local/pxf
export PXF_BASE=${HOME}/pxf-base
chown -R gpadmin:gpadmin "${GPHOME}" "${PXF_HOME}"
Review Comment:
No. I am talking about changing file permissions: `chown -R gpadmin:gpadmin
"${GPHOME}" "${PXF_HOME}"`.
TLDR: **Let's leave it AS IS for now**
PXF is by design broken here:
```
pxf register - install extension to $GPHOME
pxf prepare - creates configuration in $PXF_BASE
```
These commands are being executed on all hosts using standard passwordless
ssh => it is executed using `gpadmin` user. That's why
> It's recommended to change ownership to match the installing user.
However from security stand point it is bad idea - ideally local file system
should be read-only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
