lss602726449 commented on code in PR #1570:
URL: https://github.com/apache/cloudberry/pull/1570#discussion_r2785497888
##########
src/bin/pg_upgrade/check.c:
##########
@@ -1529,15 +1344,6 @@ check_for_composite_data_type_usage(ClusterInfo *cluster)
"| drop the problem columns and restart the
upgrade.\n"
"| A list of the problem columns is in the
file:\n"
"| %s\n\n", output_path);
-=======
- pg_log(PG_REPORT, "fatal");
- pg_fatal("Your installation contains system-defined composite
types in user tables.\n"
- "These type OIDs are not stable across
PostgreSQL versions,\n"
- "so this cluster cannot currently be upgraded.
You can\n"
- "drop the problem columns and restart the
upgrade.\n"
- "A list of the problem columns is in the
file:\n"
- " %s", output_path);
Review Comment:
They have the same meaning, but I think the GP version is better, so I kept
the GP version.
<img width="922" height="704" alt="Image"
src="https://github.com/user-attachments/assets/54073fda-5d04-4d96-bba9-4cb0b559b78f";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
