ostinru commented on code in PR #72:
URL: https://github.com/apache/cloudberry-pxf/pull/72#discussion_r2888191369
##########
server/build.gradle:
##########
@@ -266,6 +267,7 @@ configure(javaProjects) {
"-Xlint:empty", "-Xlint:finally", "-Xlint:overrides",
"-Xlint:path", "-Xlint:-processing", "-Xlint:static",
"-Xlint:try", "-Xlint:fallthrough", "-Xlint:unchecked",
"-Xlint:-options", "-Werror"
]
+ options.compilerArgs +=
JavaVersion.current().isCompatibleWith(JavaVersion.VERSION_17) ?
["-Xlint:-removal"] : []
Review Comment:
Currently it complains about
```
/Users/ostinru/development/cloudberry-pxf/server/pxf-api/src/main/java/org/apache/cloudberry/pxf/api/security/GSSCredentialProvider.java:22:
warning: [removal] AccessController in java.security has been deprecated and
marked for removal
import java.security.AccessController;
^
```
It is from `JEP 411: Deprecate the Security Manager for Removal` (Java 17).
And it will work up until `JEP 486: Permanently Disable the Security
Manager` (Java 24). Probably, it will continue working.
It was added in
https://github.com/apache/cloudberry-pxf/commit/79be3d5d7c8680850ca08f00585a9e20e099f9b1
"Enabled Kerberos Constrained Delegation impersonation for secure clusters
(#707)". And... it seems that we don't have these tests running.
---
Summary: I will add a comments about which warnings we should fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
