MisterRaindrop commented on code in PR #73:
URL: https://github.com/apache/cloudberry-pxf/pull/73#discussion_r2893539532


##########
package/cloudberry-pxf-release.sh:
##########
@@ -518,16 +518,18 @@ section "Staging release: $TAG"
   export COPYFILE_DISABLE=1
   export COPY_EXTENDED_ATTRIBUTES_DISABLE=1
 
-  git archive --format=tar --prefix="apache-cloudberry-pxf-${TAG}/" "$TAG" | 
tar -x -C "$TMP_DIR"
+  # Keep -rcN in the artifact filename for RC voting, but keep the extracted
+  # top-level directory name as the main version (without -rcN).
+  git archive --format=tar --prefix="apache-cloudberry-pxf-${VERSION_FILE}/" 
"$TAG" | tar -x -C "$TMP_DIR"

Review Comment:
   apache-cloudberry-pxf no need add incubating ? example 
apache-cloudberry-pxf-2.0.0-incubating-rc1-src.tar.gz ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to