MisterRaindrop commented on issue #17:
URL: https://github.com/apache/cloudberry-pxf/issues/17#issuecomment-4132015414
> During testcontainers testing I found out that `pxf_regress` almost always
reports that test passed[1] even when PXF is completely broken. e.g. following
diff marked as OK:
>
> ```
> --- /tmp/pxf_regress_filtered_2086185166.out 2026-03-24
18:51:11.610347101 +0000
> +++ /tmp/pxf_regress_filtered_1986425128.out 2026-03-24
18:51:11.610347101 +0000
> @@ -18,4 +18,6 @@
> d_uuid
> FROM pxf_ch_clickhouse_read_types
> LIMIT 1;
> -ERROR: PXF server error : java.io.IOException: Magic is not correct -
expect [-126] but got [-109] (seg2 slice1 172.21.0.2:7004 pid=6943)
> + i_int | s_small | b_big | f_float32 | d_float64 | b_bool | dec
| t_text | bin | d_date | d_ts | d_tstz
| d_uuid
> + 1 | 2 | 3 | 1.25 | 3.1415926 | t |
12345.6789012345 | hello | \x5b36352c36362c36372c36385d | 2020-01-02 |
2020-01-02 03:04:05.006 | 2020-01-02 03:04:05.006+00 |
550e8400-e29b-41d4-a716-446655440000
> +(1 row)
> ```
>
> I have tried 2 approaches:
>
> 1. change following lines[1] to `return true` - it breaks a lot of tests.
> 2. Reverting changes in this particular file that made in
[4830298](https://github.com/apache/cloudberry-pxf/commit/483029896080525372cce935beab5685d76e63f8)
- it brakes a bit less tests.
>
> [@MisterRaindrop](https://github.com/MisterRaindrop) , I will suggest to
rollback `pxf_regress`'s changes from
[4830298](https://github.com/apache/cloudberry-pxf/commit/483029896080525372cce935beab5685d76e63f8)
in `main`. And leave CI broken for some time. HIVE and S3 tests are good
candidates for migration to testcontainers and could be fixed during migration.
Other tests should be investigated in depth.
>
> [1]
https://github.com/apache/cloudberry-pxf/blob/main/automation/pxf_regress/main.go#L338-L339
@tuhaihe How do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
