NJrslv commented on code in PR #1629:
URL: https://github.com/apache/cloudberry/pull/1629#discussion_r3008679510


##########
.github/workflows/build-deb-cloudberry.yml:
##########
@@ -448,13 +452,14 @@ jobs:
         shell: bash
         env:
           SRC_DIR: ${{ github.workspace }}
+          CONFIGURE_EXTRA_OPTS: --with-gp-stats-collector

Review Comment:
   My reasoning was not to build this extension on user that does not know 
about it, including `--with-gp-stats-collector` to `configure-cloudberry.sh` 
makes it build by default.
   
   Do you think it's better to always build our extension or build only for the 
tests (current version)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to