NJrslv commented on code in PR #1629: URL: https://github.com/apache/cloudberry/pull/1629#discussion_r3009365016
########## configure: ########## Review Comment: I didn't know that, thanks. As far as I understand it, `configure` is generated from `configure.ac`. If that's the case, we have a problem with `configure`: every commit that modifies `configure` without touching `configure.ac` gets overwritten after running autoconf. For example, the latest commit has this issue: https://github.com/apache/cloudberry/commit/7e867f605c8798979405b163a7d5c65b572edb4c. If I am not wrong, the solution would be, in this pr, to restore any changes to `configure`, create a separate pr, where we find every commit that might be overwritten by autoconf (the change is not present in `configure.ac`). We can do it in parallel, does not matter, just regenerate the `configure` in its dedicated pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
