tuhaihe commented on PR #76:
URL: https://github.com/apache/cloudberry-backup/pull/76#issuecomment-4160790488
> It seems like that the top-level extracted directory now uses
VERSION_FILE, but the tarball filename still uses TAG
(TAR_NAME="apache-cloudberry-backup-${TAG}-src.tar.gz"). If the intent is to
remove -rcN from both directory and filename, Should we also switch TAR_NAME to
use VERSION_FILE?
Hi @robertmu, thanks for your review. Good point. The ideal format will be:
- Archive name: apache-cloudberry-backup-2.1.0-incubating-rc2-src.tar.gz
(`2.1.0-incubating-rc2` is the tag name)
- Unpacked name: apache-cloudberry-backup-2.1.0-incubating (`2.1.0` is the
VERSION)
I need to update the script to let the unpacked name include the
`incubating` text in the file name. So we cannot switch `TAR_NAME` to
`VERSION_FILE` at our incubating stage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
