leborchuk commented on code in PR #1646:
URL: https://github.com/apache/cloudberry/pull/1646#discussion_r3014407239
##########
src/backend/utils/resgroup/resgroup.c:
##########
@@ -3700,7 +3700,6 @@ check_and_unassign_from_resgroup(PlannedStmt* stmt)
} while (!groupIncBypassedRef(&groupInfo));
bypassedGroup = groupInfo.group;
- bypassedGroup->totalExecuted++;
Review Comment:
Quite cumbersome logic with a totalExecuted counter. We have 5 items where
we increase the counter. But I checked the source and saw that
check_and_unassign_from_resgroup means that no active transactions are going to
be executed. So there is no need to increase the counter here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
