tuhaihe commented on PR #1629: URL: https://github.com/apache/cloudberry/pull/1629#issuecomment-4168398848
> @tuhaihe Dianjin, Hi! > > I restored the config file here (the one I was editing manually): [f26c287](https://github.com/apache/cloudberry/commit/f26c2877f03db0f0712f25770a169b35c17c4318). We'll regenerate it cleanly from configure.ac in the next PRs, I guess. > Got it, thanks. Yes, we can regenerate it later, and welcome to create a new PR to update it then. BTW, my PR on generating the new `configure` file is still in review: #1651. > > The only question is: squash or merge? This PR has quite a history of commits, so it might be useful to preserve it. But throughout our work on this extension, we've been making fix-up commits, and the history should be cleaned up - grouped before the merge. > > I don't think preserving the commit history is an extremely important option. The cleanest and easiest approach would be to squash all the commits into one and merge. What do you think? I prefer to keep the history commits, which will be important for the potential contributors to learn more about the context. Here just need some time to tidy them up ( my common way is squashing some simple and related continuous commits into one and rewording the commit title/commit message body ) and make the commits look more logical, as suggested by @my-ship-it. But it looks good to me for now. FYI. @NJrslv -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
