my-ship-it commented on code in PR #1681:
URL: https://github.com/apache/cloudberry/pull/1681#discussion_r3108423237
##########
src/backend/gpopt/config/CConfigParamMapping.cpp:
##########
@@ -331,7 +331,12 @@ CConfigParamMapping::SConfigMappingElem
CConfigParamMapping::m_elements[] = {
false, // m_negate_param
GPOS_WSZ_LIT(
"Enable create window hash agg")},
-
+
+ {EopttraceDisableStreamingHashAgg, &gp_orca_use_streaming_hashagg,
Review Comment:
ORCA-specific GUCs conventionally use the optimizer_* prefix
(optimizer_enable_hashjoin, optimizer_enable_hashagg,
optimizer_force_window_hash_agg), not
gp_*. Consider renaming to optimizer_use_streaming_hashagg or
optimizer_enable_streaming_hashagg. This also matters because the GUC must be
passed to ORCA via
CConfigParamMapping — mixing a gp_ name into the ORCA mapping list is
inconsistent with every other entry there.
##########
src/backend/gpopt/config/CConfigParamMapping.cpp:
##########
@@ -331,7 +331,12 @@ CConfigParamMapping::SConfigMappingElem
CConfigParamMapping::m_elements[] = {
false, // m_negate_param
GPOS_WSZ_LIT(
"Enable create window hash agg")},
-
+
+ {EopttraceDisableStreamingHashAgg, &gp_orca_use_streaming_hashagg,
+ true, // m_negate_param
+ GPOS_WSZ_LIT(
Review Comment:
uses QUERY_TUNING_METHOD, but all sibling ORCA toggles
(optimizer_enable_hashjoin, etc.) use DEVELOPER_OPTIONS with GUC_NO_SHOW_ALL |
GUC_NOT_IN_SAMPLE. Even the companion gp_use_streaming_hashagg has
GUC_NO_SHOW_ALL | GUC_NOT_IN_SAMPLE. The new GUC will appear in SHOW ALL /
postgresql.conf.sample while its
sibling does not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
