talmacschen-arch commented on issue #96: URL: https://github.com/apache/cloudberry-backup/issues/96#issuecomment-4342043727
Implementation note for reviewers/users tracking this issue:
PR #97 ships the env-var fallback chain behind a new opt-in flag
`--auto-load-history-db` rather than making it the default. Behavior:
- Without `--auto-load-history-db`: `gpbackman` keeps the existing
"current working directory" lookup for `gpbackup_history.db`.
- With `--auto-load-history-db`: resolution chain is
explicit `--history-db` → `$COORDINATOR_DATA_DIRECTORY` →
`$MASTER_DATA_DIRECTORY`, failing loudly if none of them yield
an existing file.
The `os.Stat` pre-check and the friendlier error message (pointing
at `--history-db`, `--auto-load-history-db`, and the env vars)
are unconditional — SQLite will no longer silently create an empty
`gpbackup_history.db` in the current directory.
This deviates slightly from the original proposal in this issue
(which suggested the env-var chain as default behavior); the opt-in
gating was added during review to keep existing workflows backward
compatible. Will close this issue once PR #97 is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
