leborchuk commented on PR #1744: URL: https://github.com/apache/cloudberry/pull/1744#issuecomment-4449847214
It will conflict with https://github.com/postgres/postgres/commit/0f65f3eec478db8ac4f217a608b4478fed023bac#diff-358df0f060121a25b138de1f148f4d3db078ba7f1aa46897f4dbbad4be724150 Also cannot understand how it could overflow here since we calculate `norm_query_buflen` as ``` /* * Allow for $n symbols to be longer than the constants they replace. * Constants must take at least one byte in text form, while a $n symbol * certainly isn't more than 11 bytes, even if n reaches INT_MAX. We * could refine that limit based on the max value of n for the current * query, but it hardly seems worth any extra effort to do so. */ norm_query_buflen = query_len + jstate->clocations_count * 10; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
