tuhaihe commented on code in PR #1760:
URL: https://github.com/apache/cloudberry/pull/1760#discussion_r3295784555
##########
GNUmakefile.in:
##########
@@ -61,24 +61,24 @@ html man:
$(MAKE) -C doc $@
install:
- $(MAKE) -C contrib/auto_explain $@
+# $(MAKE) -C contrib/auto_explain $@
$(MAKE) -C contrib/citext $@
$(MAKE) -C contrib/file_fdw $@
$(MAKE) -C contrib/formatter $@
- $(MAKE) -C contrib/formatter_fixedwidth $@
- $(MAKE) -C contrib/fuzzystrmatch $@
+# $(MAKE) -C contrib/formatter_fixedwidth $@
+# $(MAKE) -C contrib/fuzzystrmatch $@
$(MAKE) -C contrib/extprotocol $@
- $(MAKE) -C contrib/dblink $@
- $(MAKE) -C contrib/indexscan $@
+# $(MAKE) -C contrib/dblink $@
+# $(MAKE) -C contrib/indexscan $@
$(MAKE) -C contrib/interconnect $@
$(MAKE) -C contrib/pageinspect $@ # needed by src/test/isolation
- $(MAKE) -C contrib/hstore $@
- $(MAKE) -C contrib/pgcrypto $@
- $(MAKE) -C contrib/btree_gin $@
- $(MAKE) -C contrib/pg_trgm $@
- $(MAKE) -C contrib/tablefunc $@
- $(MAKE) -C contrib/passwordcheck $@
- $(MAKE) -C contrib/pg_buffercache $@
+# $(MAKE) -C contrib/hstore $@
+# $(MAKE) -C contrib/pgcrypto $@
+# $(MAKE) -C contrib/btree_gin $@
+# $(MAKE) -C contrib/pg_trgm $@
+# $(MAKE) -C contrib/tablefunc $@
+# $(MAKE) -C contrib/passwordcheck $@
+# $(MAKE) -C contrib/pg_buffercache $@
Review Comment:
Hi, is it okay to enable these contribs by now? Or do we plan to make
follow-up fixes after this PR is merged?
##########
.github/workflows/pg16-merge-validation.yml:
##########
Review Comment:
This file can be removed. We don't use it anymore.
##########
.github/workflows/apache-rat-audit.yml:
##########
@@ -32,9 +32,9 @@ name: Apache Rat License Check
on:
push:
- branches: [main, REL_2_STABLE]
+ branches: [main, cbdb-postgres-merge]
Review Comment:
We can restore the target branch from `cbdb-postgres-merge` to
`REL_2_STABLE`, since `cbdb-postgres-merge` is only for the development branch
test, right?
```suggestion
branches: [main, REL_2_STABLE]
```
##########
.cirrus.star:
##########
Review Comment:
I think we can remove the file `.cirrus.star`, `.cirrus.tasks.yml` &
`.cirrus.yml`, which are only used for PG tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
