my-ship-it commented on code in PR #1770:
URL: https://github.com/apache/cloudberry/pull/1770#discussion_r3329849303
##########
contrib/pax_storage/src/cpp/exceptions/CException.cc:
##########
@@ -206,7 +206,7 @@ void ErrorMessage::AppendV(const char *format, va_list ap)
noexcept {
const char *ErrorMessage::Message() const noexcept { return &message_[0]; }
int ErrorMessage::Length() const noexcept { return index_; }
-void CException::Raise(CException ex, bool reraise) {
+void CException::Raise(CException &ex, bool reraise) {
Review Comment:
Better to use const CException & here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
