MutableFire commented on code in PR #1829:
URL: https://github.com/apache/cloudberry/pull/1829#discussion_r3480392253
##########
contrib/interconnect/udp/ic_udpifc.c:
##########
@@ -8208,7 +8192,6 @@ SendDummyPacket(void)
pg_freeaddrinfo_all(hint.ai_family, addrs);
if (sockfd != -1)
closesocket(sockfd);
- return;
Review Comment:
No, there were no gcc warnings.
My main motivation, as described in the PR, is simply code clarity. I
believe we should avoid unnecessary lines that don't add logic, as they make
the code harder to read.
While I agree we should minimize diffs from upstream for standard PostgreSQL
code, this is our own custom code. Therefore, I think it's perfectly fine to
refine its style and clean it up.
Could you clarify your concern? Is there a specific reason you prefer
keeping these return statements?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
