echonesis commented on code in PR #1833:
URL: https://github.com/apache/cloudberry/pull/1833#discussion_r3482831341
##########
doc/src/sgml/rules.sgml:
##########
@@ -1253,14 +1253,14 @@ Time: 13.068 ms
automatically if possible. If the view definition query has a GROUP BY
clause, a unique
index is created on the columns of GROUP BY expressions. Also, if the
view has DISTINCT
clause, a unique index is created on all columns in the target list.
Otherwise, if the
- view contains all primary key attritubes of its base tables in the target
list, a unique
- index is created on these attritubes. In other cases, no index is created.
+ view contains all primary key attributes of its base tables in the target
list, a unique
+ index is created on these attributes. In other cases, no index is created.
</para>
<para>
In the previous example, a unique index "mv_ivm_index" is created on aid
and bid
columns of materialized view "mv_ivm", and this enables the rapid update
of the view.
- Dropping this index make updating the view take a loger time.
+ Dropping this index make updating the view take a longer time.
Review Comment:
Thank you for the suggestion and the encouraging words!
I haven't observed this specific issue in the upstream PostgreSQL repository
so far, but I will certainly keep a close eye on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]