chenjinbao1989 commented on code in PR #1827:
URL: https://github.com/apache/cloudberry/pull/1827#discussion_r3525177038
##########
src/backend/commands/subscriptioncmds.c:
##########
@@ -672,6 +672,13 @@ CreateSubscription(ParseState *pstate,
CreateSubscriptionStmt *stmt,
opts.synchronous_commit = "off";
conninfo = stmt->conninfo;
+ /*
+ * conninfo can be an empty string, but the serialization
+ * doesn't distinguish an empty string from NULL. The
+ * code that executes the command in't prepared for a NULL.
+ */
+ if (conninfo == NULL)
+ conninfo = pstrdup("");
Review Comment:
In this context, "" is considered a valid value. Therefore, we only need to
convert the format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
