andr-sokolov commented on code in PR #1842: URL: https://github.com/apache/cloudberry/pull/1842#discussion_r3535306719
########## src/test/regress/sql/lake_table.sql: ########## @@ -0,0 +1,142 @@ +-- +-- Test lake table DDL: FOREIGN CATALOG, FOREIGN VOLUME, ICEBERG TABLE +-- + +-- Display the lake table catalogs +\d+ pg_foreign_catalog +\d+ pg_foreign_volume +\d+ pg_lake_table + +-- Setup: foreign servers for the catalogs and volumes to hang off +CREATE FOREIGN DATA WRAPPER lake_test_fdw; +CREATE SERVER lake_test_srv FOREIGN DATA WRAPPER lake_test_fdw; +CREATE SERVER lake_test_srv2 FOREIGN DATA WRAPPER lake_test_fdw; + +-- CREATE FOREIGN CATALOG +CREATE FOREIGN CATALOG lake_test_cat SERVER lake_test_srv OPTIONS (type 'hive', uri 'thrift://localhost:9083'); Review Comment: May be. But I think every catalog has its type. So type is not an option, but a required property, which should be in `pg_foreign_catalog` as a column and in grammar -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
