chenjinbao1989 opened a new pull request, #106:
URL: https://github.com/apache/cloudberry-backup/pull/106

   …or PG16
   
   backup/queries_externals.go: gp_exttable_fdw represents an unset 
rejectlimittype as char(-1) ('\377'), not SQL NULL, so 
GetExternalTableDefinitions was leaking that sentinel through instead of 
coalescing it to ''.
   
   backup/queries_functions.go: GetForeignDataWrappers and GetForeignServers 
had no ORDER BY, so Postgres could return rows in a nondeterministic order.
   
   integration/metadata_globals_*_test.go: PG16 reworked role-grant semantics 
so an implicit grantor always resolves to the bootstrap superuser rather than 
the acting (super)user, and an explicit GRANTED BY <role> now requires that 
role to actually hold ADMIN OPTION. Updated fixtures accordingly, and skipped 
"handles dropped granter" since PG16's grantor dependency tracking means a role 
can no longer be dropped while still recorded as another membership's grantor.
   
   integration/postdata_create_test.go: updated a hardcoded view-definition 
golden string to match PG16 ruleutils, which no longer qualifies column 
references with the table name when only one table is in the FROM clause.
   
   <!--Thank you for contributing! -->
   
   <!--In case of an existing issue or discussions, please reference it-->
   closes: #ISSUE_Number
   <!--Remove this section if no corresponding issue.-->
   
   ---
   
   ## Change logs
   
   > Describe your change clearly, including what problem is being solved or 
what document is being added or updated.
   
   ## Contributor's checklist
   
   Here are some reminders before you submit your pull request:
   
   * Make sure that your Pull Request has a clear title and commit message. You 
can take the [Git commit 
template](https://github.com/apache/cloudberry/blob/main/.gitmessage) as a 
reference.
   * Learn the [code 
contribution](https://cloudberry.apache.org/contribute/code) and [doc 
contribution](https://cloudberry.apache.org/contribute/doc) guides for better 
collaboration.
   * Make sure that CICD workflow is successful.
   * List your communications in the [GitHub 
Issues](https://github.com/apache/cloudberry-backup/issues) or 
[Discussions](https://github.com/apache/cloudberry/discussions) (if has or 
needed).
   * Feel free to ask for the [cloudberry 
committers](https://github.com/orgs/apache/teams/cloudberry-committers) or 
other people to help review and approve.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to