fairyfar opened a new pull request, #1845:
URL: https://github.com/apache/cloudberry/pull/1845
<!-- Thank you for your contribution to Apache Cloudberry (Incubating)! -->
### What does this PR do?
<!-- Brief overview of the changes, including any major features or fixes -->
When resource groups are enabled, StartTransaction() may have taken a
catalog snapshot
within GetResGroupIdForRole, and xmin is not InvalidTransactionId.
Therefore, it does
not meet the status requirements for "CREATE INDEX CONCURRENTLY".
Reproduction method:
1. Compile Debug version and enable assert.
```
./configure --enable-debug --enable-cassert
```
2. Enable resource group management.
```
gp_resource_manager='group'
```
3. Test Case
```
create table t(a text, b text);
-- crash:
create index concurrently t_idx on t(a, b);
-- "ERROR: relation "t_idx" already exists". Indicates that the transaction
has been successfully committed.
create index concurrently t_idx on t(a, b);
```
4. Test Results
```
[fairyfar@bogon cloudberry]$ psql postgres
psql (16.9, server 16.9)
Type "help" for help.
postgres=# create table t(a text, b text);
NOTICE: Table doesn't have 'DISTRIBUTED BY' clause -- Using column named
'a' as the Apache Cloudberry data distribution key for this table.
HINT: The 'DISTRIBUTED BY' clause determines the distribution of data. Make
sure column(s) chosen are the optimal data distribution key to minimize skew.
CREATE TABLE
postgres=# create index concurrently t_idx on t(a, b);
FATAL: Unexpected internal error (assert.c:46)
DETAIL: ("MyProc->xid == InvalidTransactionId && MyProc->xmin ==
InvalidTransactionId", File: "indexcmds.c", Line: 5459)
server closed the connection unexpectedly
This probably means the server terminated abnormally
before or while processing the request.
The connection to the server was lost. Attempting reset: Failed.
The connection to the server was lost. Attempting reset: Failed.
!?> \q
[fairyfar@bogon cloudberry]$ psql postgres
psql (16.9, server 16.9)
Type "help" for help.
postgres=# create index concurrently t_idx on t(a, b);
ERROR: relation "t_idx" already exists
```
### Type of Change
- [x] Bug fix (non-breaking change)
- [ ] New feature (non-breaking change)
- [ ] Breaking change (fix or feature with breaking changes)
- [ ] Documentation update
### Breaking Changes
<!-- Remove if not applicable. If yes, explain impact and migration path -->
### Test Plan
<!-- How did you test these changes? -->
- [ ] Unit tests added/updated
- [ ] Integration tests added/updated
- [ ] Passed `make installcheck`
- [ ] Passed `make -C src/test installcheck-cbdb-parallel`
### Impact
<!-- Remove sections that don't apply -->
**Performance:**
<!-- Any performance implications? -->
**User-facing changes:**
<!-- Any changes visible to users? -->
**Dependencies:**
<!-- New dependencies or version changes? -->
### Checklist
- [ ] Followed [contribution
guide](https://cloudberry.apache.org/contribute/code)
- [ ] Added/updated documentation
- [ ] Reviewed code for security implications
- [ ] This PR contains AI-assisted code generation
- [ ] Requested review from [cloudberry
committers](https://github.com/orgs/apache/teams/cloudberry-committers)
### Additional Context
<!-- Any other information that would help reviewers? Remove if none -->
### CI Skip Instructions
<!--
To skip CI builds, add the appropriate CI skip identifier to your PR title.
The identifier must:
- Be in square brackets []
- Include the word "ci" and either "skip" or "no"
- Only use for documentation-only changes or when absolutely necessary
-->
---
<!-- Join our community:
- Mailing list:
[[email protected]](https://lists.apache.org/[email protected])
(subscribe: [email protected])
- Discussions: https://github.com/apache/cloudberry/discussions -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
