Copilot commented on code in PR #109:
URL: https://github.com/apache/cloudberry-pxf/pull/109#discussion_r3560116161
##########
.github/workflows/pxf-ci.yml:
##########
@@ -218,7 +218,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
- java: [ '8', '11', '17' ]
+ java: [ '8', '11', '17', '21' ]
Review Comment:
Gradle 8.x requires Java 17+ to run. With the wrapper bumped to 8.14.4, this
job will fail on the '8' and '11' matrix entries because Gradle itself will be
launched with that JDK from actions/setup-java. Either drop 8/11 from the
matrix or rework the job to run Gradle on 17+ and test compatibility via
toolchains.
##########
automation/src/main/resources/testcontainers/pxf-cbdb/Dockerfile:
##########
@@ -37,14 +37,15 @@ RUN if command -v apt-get >/dev/null 2>&1; then \
# Install Gradle and warm wrapper cache (it will download GRADLE_VERSION again)
# (version must match server/gradle/wrapper/gradle-wrapper.properties)
-ARG GRADLE_VERSION=7.6.6
+ARG GRADLE_VERSION=8.14.4
Review Comment:
Gradle 8.x requires Java 17+ to run. This Dockerfile still installs Java 11,
but then runs `gradle init` / `gradle wrapper` to warm the wrapper cache; with
Gradle 8.14.4 this will fail unless the base image already provides a newer
JDK. Update the installed JDK to 17 (or 21) so the Gradle warm-up step is
reliable.
##########
.github/workflows/pxf-ci.yml:
##########
@@ -218,7 +218,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
- java: [ '8', '11', '17' ]
+ java: [ '8', '11', '17', '21' ]
Review Comment:
Beyond this matrix job, updating the Gradle wrapper to 8.14.4 means any
workflow step that runs `make -C server ...` will need Gradle to run on Java
17+. This workflow currently defaults to `env.JAVA_VERSION: "11"` and sets
`env.JAVA_HOME` to a Java 11 path, which is incompatible with Gradle 8 and is
likely to break other jobs that invoke the Gradle wrapper (e.g., stage builds
and Testcontainers tests).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
