tuhaihe commented on issue #126: URL: https://github.com/apache/cloudberry-pxf/issues/126#issuecomment-4955709598
> +1, why not? If we can make the projects more closely related and the license allows us to do so, let's do it. Users will be grateful. > > There is one consideration. I would not take the code as-is. It is necessary to make a code review. Unfortunately, Greengage code belongs to one company, so the release is tied to the requirements of commercial customers. The developer needs time to freeze the code by a certain date and release. Sometimes this leads to the need to agree to "cut corners" and "do it here and now". > > Also, we may need to adopt it to our testing system. Thanks for the feedback. I agree that we should not simply cherry-pick the code as-is. The goal is to reuse the existing implementation while ensuring it meets Apache Cloudberry PXF quality standards, including code review, dependency checks, and CI/test adaptation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
