Copilot commented on code in PR #1859:
URL: https://github.com/apache/cloudberry/pull/1859#discussion_r3637587880
##########
.github/workflows/build-deb-cloudberry.yml:
##########
@@ -280,6 +285,15 @@ jobs:
get_defaults * .'
}
+ # Determine ubuntu versions
+ UBUNTU_INPUT="${{ github.event.inputs.ubuntu_version }}"
+ if [[ "$UBUNTU_INPUT" == "all" || -z "$UBUNTU_INPUT" ]]; then
+ UBUNTU_VERSIONS_JSON='["22.04","24.04"]'
+ else
+ UBUNTU_VERSIONS_JSON=$(echo "$UBUNTU_INPUT" | jq -R 'split(",") |
map(.)')
+ fi
Review Comment:
The manual `ubuntu_version` input is parsed with `jq -R 'split(",") |
map(.)'`, which preserves whitespace. Inputs like `22.04, 24.04` will produce
`" 24.04"` and later break container image/artifact names that assume exact
versions. Trim whitespace (and drop empty entries) when building
`UBUNTU_VERSIONS_JSON`.
##########
.github/workflows/build-deb-cloudberry.yml:
##########
@@ -353,8 +374,13 @@ jobs:
outputs:
build_timestamp: ${{ steps.set_timestamp.outputs.timestamp }}
+ strategy:
+ fail-fast: false
Review Comment:
`build_timestamp` is produced inside `build-deb`, which is now a matrix job.
Downstream jobs use `needs.build-deb.outputs.build_timestamp` for artifact
names, but matrix job outputs are not version-specific (and can effectively
come from a single matrix run), so the timestamp used downstream may not
correspond to the `matrix.ubuntu_version` build that produced the
artifacts/logs you're looking at.
##########
.github/workflows/build-deb-cloudberry.yml:
##########
@@ -353,8 +374,13 @@ jobs:
outputs:
build_timestamp: ${{ steps.set_timestamp.outputs.timestamp }}
+ strategy:
+ fail-fast: false
+ matrix:
+ ubuntu_version: ['22.04', '24.04']
+
Review Comment:
`build-deb` now runs as a 22.04/24.04 matrix job, but the DEB packaging step
later in the job still copies packaging files from
`devops/build/packaging/deb/ubuntu22.04/*`. That means the 24.04 matrix run
will use the 22.04 packaging definition (previously 24.04 used
`ubuntu24.04/*`), which is very likely to produce incorrect or failing packages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
