Alena0704 commented on PR #1865: URL: https://github.com/apache/cloudberry/pull/1865#issuecomment-5093606558
LGTM. I think you should rephrase the commit message. Maybe like that ``` Fix segfault in ExplainNode() on a QE A receiving Motion has no child PlanState when its child slice runs on another gang. ExplainNode() recursed into it anyway and crashed. Return early when planstate is NULL. ``` As far as I see this code is unreachable in-tree. The only callers of ExplainPrintPlan() are ExplainOnePlan(), which runs on the QD (for example, in auto_explain - it returns from _PG_init when Gp_role != GP_ROLE_DISPATCH (contrib/auto_explain/auto_explain.c:101)) - so it never installs its hooks on a segment. Only an out-of-tree extension loaded on the segments can hit this path or debuggers today. That's fine as a hardening fix, but I think you should state it explicitly in the commit message. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
