Alena0704 commented on PR #1932: URL: https://github.com/apache/cloudberry/pull/1932#issuecomment-5449597724
> The original PR is still open, see my comments: [#1762 (comment)](https://github.com/apache/cloudberry/pull/1762#issuecomment-5448086971) Suggest holding this PR to avoid divergence. Fair point on the heads-up - that's on me, I should have pinged you before opening #1932. It wasn't meant to take the work over: authorship is yours, the six original commits are kept separate and attributed, changed only where the PG16 rebase required it. I'm not ignoring your PR - I'm trying to get your ideas committed. Two things prevent that. First, the PR is very large, 98 commits, so it's very difficult to review and check that everything is fine. I only took the first point, and already there I found bugs, which I then fixed, plus a build issue in the form of a complaining compiler. One of those bugs is still present in your branch: quals are pushed into a CTE that contains volatile functions, while the inlined path in the same function refuses to do that. WITH x AS (SELECT a, nextval('ts') FROM vol_test) SELECT * FROM x WHERE a = 3 evaluates nextval() once instead of once per row, so the value of the CTE's column changes. Another one only shows up once point #1 is taken on its own: rows are lost when one CTE reference has no pushdown-safe qual, because the guard for that sits in 54930251e4c, which belongs to point #2. Same story with the expected files - tpcds_q04.out and the singlenode copy of subselect.out are only updated at the very end of the series, in 81d2f57e4d3 and b1f84b8902e, and the pax copy isn't updated anywhere, so point #1 on its own leaves them stale. Second, all the commits have fallen behind the main branch and need rebasing. I can't do this in your branch, which is why this PR appeared. Without resolving these issues, we'll never push anything. Happy to go either way: if you want to rebase and split #1762 yourself, I'll close #1932 and you're welcome to take these five fix commits into your branch. If you'd rather not do the rebase, I'll keep #1932 as the landing path for #1 and coordinate with you before starting on #2. Whichever you prefer - just say which. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
