ZTE-EBASE commented on code in PR #1887:
URL: https://github.com/apache/cloudberry/pull/1887#discussion_r3891481834
##########
src/bin/gpfdist/regress/Makefile:
##########
@@ -33,7 +37,20 @@ ifeq ($(with_zstd),yes)
for name in `seq 1 1000`; \
do \
head -100 data/gpfdist2/lineitem.tbl >>
data/gpfdist2/lineitem.tbl.long; \
- done
+ done
+endif
+ifeq ($(with_lzo),yes)
+ # Prepare data files in case the lzop tool is not available on the
environment.
+ # The LZO-compressed files (lineitem.tbl.lzo and lineitem.tbl.long.lzo)
are pre-generated
+ # and included in the repository. Uncomment the following lines if you
need to regenerate them:
+ # rm -rf data/gpfdist2/lineitem.tbl.lzo
data/gpfdist2/lineitem.tbl.long.lzo
+ # lzop -o data/gpfdist2/lineitem.tbl.lzo data/gpfdist2/lineitem.tbl
+ # for name in `seq 1 1000`; \
+ # do \
+ # head -100 data/gpfdist2/lineitem.tbl >>
data/gpfdist2/lineitem.tbl.long.tmp; \
+ # done
Review Comment:
The comments describe the steps I followed to construct the dataset.
The reason lineitem.tbl.long.lzo is checked in as a pre-generated binary
file is that it requires the lzop command to generate. I'm not sure whether the
Apache project's CI/CD pipeline has lzop installed in its build environment. If
it doesn't, dynamically generating this file during test execution would cause
the build to fail. That's why I opted to provide it as a pre-generated artifact
for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
