tuhaihe commented on code in PR #1934:
URL: https://github.com/apache/cloudberry/pull/1934#discussion_r3902726645
##########
gpcontrib/gp_stats_collector/protos/yagpcc_metrics.proto:
##########
Review Comment:
Once the YAGPCC is donated to the ASF, the new project will be called
`cloudberry-command-center'. So, is it better to align this new project name?
##########
LICENSE:
##########
@@ -200,6 +200,28 @@
See the License for the specific language governing permissions and
limitations under the License.
+================================================================================
+This product includes software derived from pg_query_state
+(https://github.com/postgrespro/pg_query_state), under the PostgreSQL License:
+
+ Copyright (c) 2016-2025, Postgres Professional
+
+ Permission to use, copy, modify, and distribute this software and its
+ documentation for any purpose, without fee, and without a written agreement
+ is hereby granted, provided that the above copyright notice and this
+ paragraph and the following two paragraphs appear in all copies.
+
+ IN NO EVENT SHALL POSTGRES PROFESSIONAL BE LIABLE TO ANY PARTY FOR DIRECT,
+ INDIRECT, SPECIAL, INCIDENTAL, OR CONSEQUENTIAL DAMAGES, INCLUDING LOST
+ PROFITS, ARISING OUT OF THE USE OF THIS SOFTWARE AND ITS DOCUMENTATION, EVEN
+ IF POSTGRES PROFESSIONAL HAS BEEN ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+ POSTGRES PROFESSIONAL SPECIFICALLY DISCLAIMS ANY WARRANTIES, INCLUDING, BUT
+ NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A
+ PARTICULAR PURPOSE. THE SOFTWARE PROVIDED HEREUNDER IS ON AN "AS IS" BASIS,
+ AND POSTGRES PROFESSIONAL HAS NO OBLIGATIONS TO PROVIDE MAINTENANCE,
SUPPORT,
+ UPDATES, ENHANCEMENTS, OR MODIFICATIONS.
+
Review Comment:
You can append it to the `Apache Cloudberry includes codes from this file `
part.
##########
gpcontrib/gp_stats_collector/test/crash/README.md:
##########
Review Comment:
We can also add the standard ASF license header for `.md` file.
##########
.github/workflows/gpsc-ci.yaml:
##########
Review Comment:
Any possibility that we could integrate this into the existing CI workflow?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
