Copilot commented on code in PR #1944:
URL: https://github.com/apache/cloudberry/pull/1944#discussion_r3912068570
##########
configure:
##########
@@ -9567,8 +9567,13 @@ $as_echo "#define HAVE_ZSTD 1" >>confdefs.h
fi
- # Check liburing
- { $as_echo "$as_me:${as_lineno-$LINENO}: checking for io_uring_queue_init in
-luring" >&5
+ # Check liburing. liburing is Linux-only (io_uring kernel iface, 5.1+).
+ # On Linux it is required as before; on non-Linux hosts (macOS / *BSD)
+ # PAX falls back to pread-based SyncFastIO and the IOUringFastIO path
+ # is conditionally compiled — see contrib/pax_storage/src/cpp/comm/fast_io.*
+ case $host_os in
Review Comment:
The PR description says the `configure` script change is only a version
bump, but this hunk also changes the generated liburing detection logic
structure (duplicated `AC_CHECK_LIB` expansion under a `case $host_os`), which
is a functional regeneration difference. Please confirm this is intentional and
update the PR description (or split out the regeneration-only change) so
reviewers/release managers can track behavior changes explicitly.
##########
configure.ac:
##########
@@ -20,7 +20,7 @@ m4_pattern_forbid(^PGAC_)dnl to catch undefined macros
dnl The PACKAGE_VERSION from upstream PostgreSQL is maintained in the
dnl PG_PACKAGE_VERSION variable, when merging make sure to update this
dnl variable with the merge conflict from the AC_INIT() statement.
-AC_INIT([Apache Cloudberry], [2.1.0-incubating], [[email protected]],
[], [https://cloudberry.apache.org/])
+AC_INIT([Apache Cloudberry], [2.2.0-incubating], [[email protected]],
[], [https://cloudberry.apache.org/])
Review Comment:
Release version appears to still be hardcoded as `2.1.0-incubating` in at
least `devops/sandbox/Dockerfile.RELEASE.rockylinux9` (ARG
`CB_RELEASE_VERSION=2.1.0-incubating`). If this PR is meant to fully bump the
release version to `2.2.0-incubating`, that reference should likely be updated
too (and any other tooling that downloads the official tarball).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
