MutableFire commented on code in PR #1848:
URL: https://github.com/apache/cloudberry/pull/1848#discussion_r3923202324
##########
gpMgmt/bin/gpexpand:
##########
@@ -846,6 +846,24 @@ class SegmentTemplate:
# and mirror information
update_pg_hba_on_segments(self.gparray, self.isHbaHostnames,
self.batch_size, expanded_host_content)
+ new_segments = self.gparray.getExpansionSegDbList()
+ chmod_commands_by_host = defaultdict(list)
+
+ for seg in new_segments:
+ if seg.isSegmentMirror():
Review Comment:
Mirrors are excluded because they are not started or manipulated during this
phase of gpexpand. They are initialized as passive copies and are only brought
up later during the gprecoverseg synchronization step. The permission fix here
is targeted at the active primaries that we are about to start, clean, and
stop. The mirror permissions will be validated/corrected when they are first
synchronized.
##########
gpMgmt/bin/gpexpand:
##########
@@ -846,6 +846,24 @@ class SegmentTemplate:
# and mirror information
update_pg_hba_on_segments(self.gparray, self.isHbaHostnames,
self.batch_size, expanded_host_content)
+ new_segments = self.gparray.getExpansionSegDbList()
+ chmod_commands_by_host = defaultdict(list)
+
+ for seg in new_segments:
+ if seg.isSegmentMirror():
Review Comment:
Mirrors are excluded because they are not started or manipulated during this
phase of gpexpand. They are initialized as passive copies and are only brought
up later during the gprecoverseg synchronization step. The permission fix here
is targeted at the active primaries that we are about to start, clean, and
stop. The mirror permissions will be validated/corrected when they are first
synchronized
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
