yjhjstz opened a new pull request, #1957:
URL: https://github.com/apache/cloudberry/pull/1957
Since 37224a3d171 CXformUtils::PdrgpcrIndexKeys() has been a thin wrapper
around PdrgpcrIndexColumns(), which appends the index's INCLUDE columns after
its key columns. CPredicateUtils::ExtractIndexPredicates() therefore treated a
predicate on an INCLUDE-only column as indexable. Ordinary comparisons were
still rejected later by CMDIndexGPDB::IsCompatible(), but the shortcuts for
boolean column references (col -> col = true, NOT col -> col = false) and for
IS [NOT] NULL bypass that check and went straight into the index condition list.
The DXL-to-plan translator then maps the column through GetKeyPos(), which
returns ulong_max for a non-key column, so the Var's varattno wrapped to 0 and
execution failed with
ERROR: bogus index qualification (nodeIndexscan.c:1250)
or, for IS [NOT] NULL,
ERROR: btree index keys must be ordered by attribute (nbtutils.c:777)
Restore the key-only semantics: reintroduce the EIndexCols selector (EicKey
/ EicKeyAndIncluded) on PdrgpcrIndexColumns()/PcrsIndexColumns() and make
PdrgpcrIndexKeys()/PcrsIndexKeys() request key columns only. The cost model
keeps asking for key + INCLUDE columns so that ComputeUnusedIndexWeight()
costing is unchanged.
Index-only-scan coverage checks are unaffected: they already use
PcrsIndexReturnableColumns().
Add regression coverage to gp_covering_index.
Fixes #1948
Fixes #ISSUE_Number
### What does this PR do?
<!-- Brief overview of the changes, including any major features or fixes -->
### Type of Change
- [ ] Bug fix (non-breaking change)
- [ ] New feature (non-breaking change)
- [ ] Breaking change (fix or feature with breaking changes)
- [ ] Documentation update
### Breaking Changes
<!-- Remove if not applicable. If yes, explain impact and migration path -->
### Test Plan
<!-- How did you test these changes? -->
- [ ] Unit tests added/updated
- [ ] Integration tests added/updated
- [ ] Passed `make installcheck`
- [ ] Passed `make -C src/test installcheck-cbdb-parallel`
### Impact
<!-- Remove sections that don't apply -->
**Performance:**
<!-- Any performance implications? -->
**User-facing changes:**
<!-- Any changes visible to users? -->
**Dependencies:**
<!-- New dependencies or version changes? -->
### Checklist
- [ ] Followed [contribution
guide](https://cloudberry.apache.org/contribute/code)
- [ ] Added/updated documentation
- [ ] Reviewed code for security implications
- [ ] This PR contains AI-assisted code generation
- [ ] Requested review from [cloudberry
committers](https://github.com/orgs/apache/teams/cloudberry-committers)
### Additional Context
<!-- Any other information that would help reviewers? Remove if none -->
### CI Skip Instructions
<!--
To skip CI builds, add the appropriate CI skip identifier to your PR title.
The identifier must:
- Be in square brackets []
- Include the word "ci" and either "skip" or "no"
- Only use for documentation-only changes or when absolutely necessary
-->
---
<!-- Join our community:
- Mailing list:
[[email protected]](https://lists.apache.org/[email protected])
(subscribe: [email protected])
- Discussions: https://github.com/apache/cloudberry/discussions -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
