krylosov-aa opened a new pull request, #1982: URL: https://github.com/apache/cloudberry/pull/1982
Fixes #1677 ### What does this PR do? GCC 14 emits false `-Warray-bounds` warnings in protobuf 3.19 headers when compiling PAX. Wrap the protobuf includes in `proto_wrappers.h` with GCC diagnostic push/pop directives. This suppresses the warnings within those headers and restores diagnostics afterwards. ### Type of Change - [x] Bug fix (non-breaking change) - [ ] New feature (non-breaking change) - [ ] Breaking change (fix or feature with breaking changes) - [ ] Documentation update ### Test Plan Validated on Ubuntu 22.04 ARM64: - GCC 14.3 with protobuf 3.19.6 and `-O3`: the three warnings in `micro_partition_stats.cc` and `orc_format_reader.cc` disappear, including with `-Werror=array-bounds`. - An intentional out-of-bounds access after the includes still triggers a compiler error. - PAX builds successfully; all 21 existing tests selected by `MicroPartitionStatsTest.*:OrcTest.*` pass. - Header compilation passes with GCC 11 and Clang 14 under strict warnings. Rocky Linux 10 was not tested directly ### Checklist - [x] Followed [contribution guide](https://cloudberry.apache.org/contribute/code) - [ ] Added/updated documentation - [ ] Reviewed code for security implications - [ ] This PR contains AI-assisted code generation - [ ] Requested review from [cloudberry committers](https://github.com/orgs/apache/teams/cloudberry-committers) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
