tuhaihe opened a new pull request, #1983:
URL: https://github.com/apache/cloudberry/pull/1983

   Cloudberry builds and packages on Rocky Linux 10 already -- the build and 
test images exist and package-convenience-binaries.yml produces rocky10 RPMs 
for x86_64 and arm64 -- but the spec only carries distro-specific Requires for 
el8 and el9. On el10 the RPM therefore ships with no library dependencies at 
all beyond the common set.
   
   Add an el10 block derived from the shared libraries an el10 build actually 
links against (collected with objdump over the installed tree), mapped onto the 
packages that provide them on Rocky Linux 10.
   
   Three el10 specifics drove the package names chosen:
   
   - zlib was replaced by zlib-ng-compat.
   - libbz2, liblz4 and libperl only ship in the *-libs subpackages. Requiring 
the umbrella perl package instead would pull the whole Perl toolchain, 
including redhat-rpm-config and systemtap-sdt-devel (263 packages / 312MB 
versus 65 packages / 65MB). PL/Perl needs nothing beyond perl-libs: 
plc_perlboot.pl and plc_trusted.pl only load strict, warnings, vars, overload, 
Carp, Carp::Heavy, feature and Tie::Hash, all of which perl-libs provides.
   - a stock Rocky Linux 10 ships libcurl-minimal, which conflicts with libcurl 
while providing the same libcurl.so.4. A plain "Requires: libcurl" makes the 
package uninstallable there without --allowerasing, so the dependency is 
expressed as a rich dependency accepting either.
   
   The list also covers dependencies the el8/el9 blocks happen to miss 
(krb5-libs, openssl-libs, libgcc, libicu, liburing, protobuf); those blocks are 
left alone here to keep this change reviewable.
   
   Verified on Rocky Linux 10.1: rpmspec emits the intended Requires, every 
package exists for both x86_64 and aarch64, and a probe RPM carrying this exact 
list installs cleanly into a stock rockylinux/rockylinux:10 container.
   
   Assisted-by: Claude Code
   
   <!-- Thank you for your contribution to Apache Cloudberry (Incubating)! -->
   
   Fixes #ISSUE_Number
   
   ### What does this PR do?
   <!-- Brief overview of the changes, including any major features or fixes -->
   
   ### Type of Change
   - [ ] Bug fix (non-breaking change)
   - [ ] New feature (non-breaking change)
   - [ ] Breaking change (fix or feature with breaking changes)
   - [ ] Documentation update
   
   ### Breaking Changes
   <!-- Remove if not applicable. If yes, explain impact and migration path -->
   
   ### Test Plan
   <!-- How did you test these changes? -->
   - [ ] Unit tests added/updated
   - [ ] Integration tests added/updated
   - [ ] Passed `make installcheck`
   - [ ] Passed `make -C src/test installcheck-cbdb-parallel`
   
   ### Impact
   <!-- Remove sections that don't apply -->
   **Performance:**
   <!-- Any performance implications? -->
   
   **User-facing changes:**
   <!-- Any changes visible to users? -->
   
   **Dependencies:**
   <!-- New dependencies or version changes? -->
   
   ### Checklist
   - [ ] Followed [contribution 
guide](https://cloudberry.apache.org/contribute/code)
   - [ ] Added/updated documentation
   - [ ] Reviewed code for security implications
   - [ ] This PR contains AI-assisted code generation
   - [ ] Requested review from [cloudberry 
committers](https://github.com/orgs/apache/teams/cloudberry-committers)
   
   ### Additional Context
   <!-- Any other information that would help reviewers? Remove if none -->
   
   ### CI Skip Instructions
   <!--
   To skip CI builds, add the appropriate CI skip identifier to your PR title.
   The identifier must:
   - Be in square brackets []
   - Include the word "ci" and either "skip" or "no"
   - Only use for documentation-only changes or when absolutely necessary
   -->
   
   ---
   <!-- Join our community:
   - Mailing list: 
[[email protected]](https://lists.apache.org/[email protected])
 (subscribe: [email protected])
   - Discussions: https://github.com/apache/cloudberry/discussions -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to