leborchuk opened a new pull request, #1995:
URL: https://github.com/apache/cloudberry/pull/1995
* Add in LICENCE info about tabulate
LICENSE (root) — added the missing coverage:
1. Boost Software License 1.0 section under the tabulate/MIT area — names
the three bundled *-lite components that are not MIT, with exact paths:
- optional_lite.hpp (optional-lite, Martin Moene)
- variant_lite.hpp (variant-lite, Martin Moene)
- string_view_lite.hpp (string-view-lite, Martin Moene) — this one has no
in-tree LICENSE.* file, so it was the least visible of the three
- single_include/tabulate/tabulate.hpp — the amalgamated header, which
embeds copies of all three plus termcolor
The existing tabulate MIT entry now reads "(excluding the bundled
third-party components listed below)" so the MIT-only claim is no longer
overbroad.
2. termcolor (BSD-3-Clause) added to the BSD 3 Clause section — also bundled
by tabulate, also not MIT, and also not previously identified.
3. Ryu (Boost-1.0) added under the PostgreSQL section —
src/common/{d2s.c,d2s_full_table.h,d2s_intrinsics.h,f2s.c,ryu_common.h} and
src/include/common/shortest_dec.h. Upstream Ryu is Apache-2.0-or-Boost
dual-licensed; PostgreSQL explicitly took it under Boost, and this was a second
undeclared Boost-1.0 component in the archive.
4. Fixed dependencies/yyjson → dependency/yyjson (the declared path didn't
exist).
New files (the root LICENSE now points into licenses/ for every entry, per
existing convention):
- licenses/LICENSE-boost.txt — canonical BSL-1.0 text
- licenses/LICENSE-termcolor.txt — termcolor BSD-3 text
pom.xml — excluded those two new verbatim license texts from the Apache RAT
scan, mirroring the existing tabulate/LICENSE.termcolor exclusion (that one is
already excluded, which tells us RAT doesn't match that BSD variant).
* Add boost license files
* Fix LICENSE coverage of bundled tabulate components
Two gaps remained after the earlier commits in this PR.
The MIT entry for tabulate carved out "the bundled third-party components
listed below", and that list names
single_include/tabulate/tabulate.hpp. But that file is a three-license
composite: lines 1-5624 are variant-lite, optional-lite and string-view-lite
(Boost-1.0), ~5625-6071 are termcolor (BSD-3), and ~6072-9385 are tabulate's
own MIT code. Excluding the whole file left those last ~3300 lines covered by
nothing. Reword the carve-out so it applies to the embedded portions rather
than to whole files.
tabulate also bundles amalgamate.py by Erik Edlund under BSD-3-Clause, in
utils/amalgamate/, the tool used to generate the single header. Like termcolor
it is not covered by tabulate's own MIT license and was not declared anywhere.
Add it to the BSD 3 Clause section and ship its text as
licenses/LICENSE-amalgamate.txt.
That text uses the standard BSD-3 wording, so unlike LICENSE-termcolor.txt
it needs no Apache RAT exclusion.
* Add LICENSE info about amalgamate
---------
<!-- Thank you for your contribution to Apache Cloudberry (Incubating)! -->
Fixes #ISSUE_Number
### What does this PR do?
<!-- Brief overview of the changes, including any major features or fixes -->
### Type of Change
- [ ] Bug fix (non-breaking change)
- [ ] New feature (non-breaking change)
- [ ] Breaking change (fix or feature with breaking changes)
- [ ] Documentation update
### Breaking Changes
<!-- Remove if not applicable. If yes, explain impact and migration path -->
### Test Plan
<!-- How did you test these changes? -->
- [ ] Unit tests added/updated
- [ ] Integration tests added/updated
- [ ] Passed `make installcheck`
- [ ] Passed `make -C src/test installcheck-cbdb-parallel`
### Impact
<!-- Remove sections that don't apply -->
**Performance:**
<!-- Any performance implications? -->
**User-facing changes:**
<!-- Any changes visible to users? -->
**Dependencies:**
<!-- New dependencies or version changes? -->
### Checklist
- [ ] Followed [contribution
guide](https://cloudberry.apache.org/contribute/code)
- [ ] Added/updated documentation
- [ ] Reviewed code for security implications
- [ ] This PR contains AI-assisted code generation
- [ ] Requested review from [cloudberry
committers](https://github.com/orgs/apache/teams/cloudberry-committers)
### Additional Context
<!-- Any other information that would help reviewers? Remove if none -->
### CI Skip Instructions
<!--
To skip CI builds, add the appropriate CI skip identifier to your PR title.
The identifier must:
- Be in square brackets []
- Include the word "ci" and either "skip" or "no"
- Only use for documentation-only changes or when absolutely necessary
-->
---
<!-- Join our community:
- Mailing list:
[[email protected]](https://lists.apache.org/[email protected])
(subscribe: [email protected])
- Discussions: https://github.com/apache/cloudberry/discussions -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
