tuhaihe opened a new pull request, #1997:
URL: https://github.com/apache/cloudberry/pull/1997
src/port/glob.c, src/port/glob.h and src/include/port/win32_msvc/glob.h
carry the original 4-clause BSD license from the Regents of the University of
California, with the advertising clause intact. The ASF lists that variant
under Category X, which may not be distributed in source or binary form, and
the files have shipped in every release so far. Reported by Justin Mclean
during the 2.2.0-rc1 IPMC vote.
The files are not PostgreSQL code and can simply go away:
- PostgreSQL has no glob.c, glob.h or win32_msvc/glob.h on master,
REL_16_STABLE or REL_14_STABLE; upstream's win32_msvc directory holds only
dirent.h, sys, unistd.h and utime.h. src/port/glob.c still carries a PHP CVS
keyword ($Id: glob.c,v 1.7 2007/11/10 09:56:37 dmitry Exp $), so it came from
PHP's win32 glob by way of Greenplum, and src/port/glob.h arrived with "Move
gpfdist to gpdb core".
- The only consumers are the Windows gpfdist builds. In
src/bin/gpfdist/Makefile the object was added under ifeq ($(PORTNAME),win32),
and src/bin/gpfdist/CMakeLists.txt is a standalone MSVC project (/MP /wd4996
compiler switches, ws2_32 and Crypt32, libapr-1.lib) that nothing in the build
system invokes. Cloudberry neither supports nor produces Windows builds.
- The two places that really use glob, src/backend/utils/adt/dbsize.c and
src/backend/utils/misc/fstream/fstream.c, include <glob.h> and resolve to the
system header.
The win32 block in the gpfdist Makefile is removed whole rather than
trimmed: its -I$(top_builddir)/src/port was added by the same commit that added
src/port/glob.h and existed only to find that header.
The LICENSE section covering these files and licenses/LICENSE-glob.txt go
with them. Note that the section listed only two of the three files;
src/port/glob.h was never registered.
Checked on Rocky 9 that no reference to glob.c, glob.o or LICENSE-glob
remains anywhere in the tree, and that gpfdist builds byte-identically before
and after (133152 bytes) and still runs; PORTNAME is linux there, so the
removed block never fired to begin with.
Assisted-by: Claude Code
Backpatch-through: REL_2_STABLE
<!-- Thank you for your contribution to Apache Cloudberry (Incubating)! -->
Fixes #ISSUE_Number
### What does this PR do?
<!-- Brief overview of the changes, including any major features or fixes -->
### Type of Change
- [ ] Bug fix (non-breaking change)
- [ ] New feature (non-breaking change)
- [ ] Breaking change (fix or feature with breaking changes)
- [ ] Documentation update
### Breaking Changes
<!-- Remove if not applicable. If yes, explain impact and migration path -->
### Test Plan
<!-- How did you test these changes? -->
- [ ] Unit tests added/updated
- [ ] Integration tests added/updated
- [ ] Passed `make installcheck`
- [ ] Passed `make -C src/test installcheck-cbdb-parallel`
### Impact
<!-- Remove sections that don't apply -->
**Performance:**
<!-- Any performance implications? -->
**User-facing changes:**
<!-- Any changes visible to users? -->
**Dependencies:**
<!-- New dependencies or version changes? -->
### Checklist
- [ ] Followed [contribution
guide](https://cloudberry.apache.org/contribute/code)
- [ ] Added/updated documentation
- [ ] Reviewed code for security implications
- [ ] This PR contains AI-assisted code generation
- [ ] Requested review from [cloudberry
committers](https://github.com/orgs/apache/teams/cloudberry-committers)
### Additional Context
<!-- Any other information that would help reviewers? Remove if none -->
### CI Skip Instructions
<!--
To skip CI builds, add the appropriate CI skip identifier to your PR title.
The identifier must:
- Be in square brackets []
- Include the word "ci" and either "skip" or "no"
- Only use for documentation-only changes or when absolutely necessary
-->
---
<!-- Join our community:
- Mailing list:
[[email protected]](https://lists.apache.org/[email protected])
(subscribe: [email protected])
- Discussions: https://github.com/apache/cloudberry/discussions -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
