tuhaihe opened a new pull request, #1999:
URL: https://github.com/apache/cloudberry/pull/1999
Justin Mclean flagged three Thumbs.db files in the source archive during the
2.2.0-rc1 IPMC vote. One of them sits in gpAux/client, and looking at what
else is in there turned up something worse.
gpAux/client is the old Greenplum Windows client MSI installer: a WiX
project, a handful of .ico and .bmp resources, two .bat scripts and
license.rtf. That last file is 853 KB of VMware End User License Agreement,
last updated 03 May 2021, a proprietary commercial agreement shipped inside an
Apache source release. greenplum-clients.wxs also still declares
Manufacturer="Pivotal, Inc." and Manufacturer="Greenplum, Inc.".
Nothing builds any of it. The only references anywhere in the tree were
seven Apache RAT exclusions in pom.xml, added so the scan would ignore these
files rather than because anything uses them. Cloudberry does not support or
produce Windows client packages and there are no plans to, so the whole
directory goes rather than just the Thumbs.db inside it.
Also removed:
- gpcontrib/orafce/doc/orafce_documentation/gif/Thumbs.db
- gpcontrib/orafce/doc/sql_migration/gif/Thumbs.db
These are Windows Explorer thumbnail caches that came along with orafce's
documentation images, 248 KB and 27 KB of binary data with no purpose in a
source tree.
pom.xml loses the seven gpAux/client exclusions, which now point at nothing,
and the **/Thumbs.db exclusion, which is what kept RAT quiet about these files.
Dropping it means a future Thumbs.db gets flagged instead of silently
excluded. .gitignore now lists Thumbs.db and ehthumbs.db so they do not come
back.
Verified on Rocky 9 against a fresh checkout of main: `mvn clean verify
-Drat.consoleOutput=true` gives Unapproved: 0, unknown: 0, generated: 1,
approved: 5651 licenses, BUILD SUCCESS.
Assisted-by: Claude Code
Backpatch-through: REL_2_STABLE
<!-- Thank you for your contribution to Apache Cloudberry (Incubating)! -->
Fixes #ISSUE_Number
### What does this PR do?
<!-- Brief overview of the changes, including any major features or fixes -->
### Type of Change
- [ ] Bug fix (non-breaking change)
- [ ] New feature (non-breaking change)
- [ ] Breaking change (fix or feature with breaking changes)
- [ ] Documentation update
### Breaking Changes
<!-- Remove if not applicable. If yes, explain impact and migration path -->
### Test Plan
<!-- How did you test these changes? -->
- [ ] Unit tests added/updated
- [ ] Integration tests added/updated
- [ ] Passed `make installcheck`
- [ ] Passed `make -C src/test installcheck-cbdb-parallel`
### Impact
<!-- Remove sections that don't apply -->
**Performance:**
<!-- Any performance implications? -->
**User-facing changes:**
<!-- Any changes visible to users? -->
**Dependencies:**
<!-- New dependencies or version changes? -->
### Checklist
- [ ] Followed [contribution
guide](https://cloudberry.apache.org/contribute/code)
- [ ] Added/updated documentation
- [ ] Reviewed code for security implications
- [ ] This PR contains AI-assisted code generation
- [ ] Requested review from [cloudberry
committers](https://github.com/orgs/apache/teams/cloudberry-committers)
### Additional Context
<!-- Any other information that would help reviewers? Remove if none -->
### CI Skip Instructions
<!--
To skip CI builds, add the appropriate CI skip identifier to your PR title.
The identifier must:
- Be in square brackets []
- Include the word "ci" and either "skip" or "no"
- Only use for documentation-only changes or when absolutely necessary
-->
---
<!-- Join our community:
- Mailing list:
[[email protected]](https://lists.apache.org/[email protected])
(subscribe: [email protected])
- Discussions: https://github.com/apache/cloudberry/discussions -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
