tuhaihe opened a new pull request, #2003:
URL: https://github.com/apache/cloudberry/pull/2003
src/backend/libpq/sha2.h carries Aaron D. Gifford's BSD 3-Clause notice and
is registered in LICENSE under it, but nothing in the tree can reach the file:
- no translation unit includes a bare "sha2.h", in src/backend/libpq or
anywhere else
- #include "libpq/sha2.h" cannot resolve to it either, because headers are
found under src/include and there is no src/include/libpq/sha2.h
The same upstream code does live in the tree, at src/common/sha2.c and
src/common/sha2_int.h, both carrying the same Aaron D. Gifford copyright and
the same OpenBSD and adg version keywords. Those two are real: sha2_int.h is
included by sha2.c, cryptohash.c, cryptohash_openssl.c and sm3.c, and sha2.c is
in src/common's object list.
So the header is a leftover duplicate. Delete it, and repoint the LICENSE
entry at the copies that are actually there rather than dropping the entry
along with the file: the BSD 3-Clause code itself has not gone anywhere, only
this stale copy of it has, and licenses/LICENSE-bsd3-sha2.txt still matches the
notice on both remaining files.
Note that the five "common/sha2.h" includes elsewhere in the tree refer to
src/include/common/sha2.h, a different and PostgreSQL-licensed file, not to
either of these.
Assisted-by: Claude Code
Backpatch-through: REL_2_STABLE
<!-- Thank you for your contribution to Apache Cloudberry (Incubating)! -->
Fixes #ISSUE_Number
### What does this PR do?
<!-- Brief overview of the changes, including any major features or fixes -->
### Type of Change
- [ ] Bug fix (non-breaking change)
- [ ] New feature (non-breaking change)
- [ ] Breaking change (fix or feature with breaking changes)
- [ ] Documentation update
### Breaking Changes
<!-- Remove if not applicable. If yes, explain impact and migration path -->
### Test Plan
<!-- How did you test these changes? -->
- [ ] Unit tests added/updated
- [ ] Integration tests added/updated
- [ ] Passed `make installcheck`
- [ ] Passed `make -C src/test installcheck-cbdb-parallel`
### Impact
<!-- Remove sections that don't apply -->
**Performance:**
<!-- Any performance implications? -->
**User-facing changes:**
<!-- Any changes visible to users? -->
**Dependencies:**
<!-- New dependencies or version changes? -->
### Checklist
- [ ] Followed [contribution
guide](https://cloudberry.apache.org/contribute/code)
- [ ] Added/updated documentation
- [ ] Reviewed code for security implications
- [ ] This PR contains AI-assisted code generation
- [ ] Requested review from [cloudberry
committers](https://github.com/orgs/apache/teams/cloudberry-committers)
### Additional Context
<!-- Any other information that would help reviewers? Remove if none -->
### CI Skip Instructions
<!--
To skip CI builds, add the appropriate CI skip identifier to your PR title.
The identifier must:
- Be in square brackets []
- Include the word "ci" and either "skip" or "no"
- Only use for documentation-only changes or when absolutely necessary
-->
---
<!-- Join our community:
- Mailing list:
[[email protected]](https://lists.apache.org/[email protected])
(subscribe: [email protected])
- Discussions: https://github.com/apache/cloudberry/discussions -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
