Waloid24 commented on code in PR #2007:
URL: https://github.com/apache/cloudberry/pull/2007#discussion_r4035534815
##########
src/backend/gporca/libnaucrates/src/statistics/CScaleFactorUtils.cpp:
##########
@@ -502,12 +502,25 @@ CScaleFactorUtils::CalcScaleFactorCumulativeConj(
const ULONG num_cols = scale_factors->Size();
CDouble scale_factor(1.0);
+ if (0 == num_cols)
Review Comment:
Well, actually, it's possible. If you look at #2006 I reuse
`CalcScaleFactorCumulativeConj` there and it's possible that there will be no
outer predicates, so in this case I expect `CalcScaleFactorCumulativeConj` will
return 1.0. This check `if (0 == num_cols)` appears due to the reusage of this
function in #2006.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
